Skip to content

fix: raise ValueError for zero input in binary_count_trailing_zeros#14938

Open
Dasmat13 wants to merge 2 commits into
TheAlgorithms:masterfrom
Dasmat13:fix/binary-count-trailing-zeros-zero
Open

fix: raise ValueError for zero input in binary_count_trailing_zeros#14938
Dasmat13 wants to merge 2 commits into
TheAlgorithms:masterfrom
Dasmat13:fix/binary-count-trailing-zeros-zero

Conversation

@Dasmat13

@Dasmat13 Dasmat13 commented Jul 15, 2026

Copy link
Copy Markdown

Describe your change:

Fixes #14479. Raises a ValueError for zero inputs since trailing zeros for zero are mathematically undefined.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes fix: off-by-one error in binary_count_trailing_zeros for zero input #14479".

@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Jul 15, 2026
@Dasmat13
Dasmat13 marked this pull request as draft July 15, 2026 01:07
@Dasmat13
Dasmat13 marked this pull request as ready for review July 16, 2026 20:16
@Dasmat13

Dasmat13 commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Thanks for the review and approval, @mindaugl! I really appreciate it.

It looks like the PR is still waiting for an approval from someone with write access before it can be merged. If you happen to know who could take a quick look, I'd really appreciate it. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mindaugl mindaugl mindaugl approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix: off-by-one error in binary_count_trailing_zeros for zero input

2 participants

@Dasmat13 @mindaugl